[WIP][DO NOT MERGE] Remove LiteralTypeForLiteral by creating IsInstance function
#5909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mecoli1219 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5909 +/- ##
==========================================
+ Coverage 36.49% 36.75% +0.26%
==========================================
Files 1296 1309 +13
Lines 109571 130941 +21370
==========================================
+ Hits 39988 48130 +8142
- Misses 65426 78624 +13198
- Partials 4157 4187 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Future-Outlier
changed the title
LiteralTypeForLiteral by creating IsInstance functionLiteralTypeForLiteral by creating IsInstance function
Future-Outlier
requested changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#5908
Why are the changes needed?
The current Tuple IDL design is complicated by this function since if we want to guess the
LiteralTypefromLiteral, we have to store the name of the tuple and the name of each field inside the tuple in theLiteral.However, guessing the
LiteralTypeis not necessary for Flyte since whenever we create a new literal, there must be a target type (maybe inputs or outputs, but they will always have a defined type). Also, almost all use cases ofLiteralTypeForLiteralare followed by a functionAreTypesCastable, we could simply combine these two functions into a function determining whether a Literal could be instantiated by a LiteralType. It is really similar toisinstance()function in Python.What changes were proposed in this pull request?
IsInstance()for the flytepropeller to check whether a Literal could be represented by a LiteralType.LiteralTypeForLiteraland update all necessary code in FlyteAdmin & FlytePropeller.LiteralTypeForLiteraltoIsInstanceHow was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Additional Concerns
Someone suggested that we shouldn't merge this PR before the release